fix(oauth): handle fields missing in the stored config when building consent url #20933
Conversation
octavia-squidington-iv
added
area/platform
pedroslopez
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
pedroslopez
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
| entry -> JsonPaths.getSingleValue(hydratedSourceConnectionConfiguration, entry.getValue()).get()))); | ||
| final Map<String, JsonNode> result = new HashMap<>(); | ||
| pathsToGet.forEach((k, v) -> { | ||
| final Optional<JsonNode> configValue = JsonPaths.getSingleValue(hydratedSourceConnectionConfiguration, v); |
There was a problem hiding this comment.
Could we instead make sure the hydratedSourceConnectionConfiguration has all the expected paths?
There was a problem hiding this comment.
The expected behavior is actually that hydratedSourceConnectionConfiguration doesn't have the path we're trying to get in this case.
Because of the way the spec is defined, credentials.subdomain is only present in the config if the OAuth authentication type has been selected (since it's only used in the oauth case)
So, if you're coming from an API key auth, your config will look something like {"credentials": {"api_token": "sometoken", "auth_type": "api_token"}}. When this method runs after switching for oauth, we try to get the value of credentials.subdomain from the existing configuration but realize it's not there. Previously since we always expected it to be present an error would be thrown. Now, we just log a warning and don't retrieve the value.
What
Fixes OC issue https://github.com/airbytehq/oncall/issues/1251
When an input used for the oauth flow is missing from the stored configuration, a
java.util.NoSuchElementException: No value presentexception was being thrown.The value not being stored in the database is expected in some scenarios, like is the case for Monday. It has a field located within the oauth credentials block (credentials.subdomain) that would only be set if the connector was previously authenticated with OAuth. Having setting up the connector with an api key, this field is not part of the saved configuration. When the OAuthHandler tries to look up the value for that field, it doesn't find anything and throws the above exception.
How
Update the implementation to only set fields in the returned config that it are present. Fields that are not present in the stored configuration will be left out from the map.